Re: [PATCH] rust: workqueue: define built-in bh queues

[Miguel Ojeda]

On Sat, Feb 22, 2025 at 5:15 AM Jarkko Sakkinen <jarkko@xxxxxxxxxx> wrote:
>
> Using 1st person plural is usually almost a cardinal sin almost and is
> somewhat exhausting to read.

Using "we" is far from a "cardinal sin" -- even key maintainers use it
sometimes.

Yes, commits should be generally written using the imperative,
especially for the sentence about the actual change itself, but it is
more natural in some cases to use "we".

> "These methods" refer to nothing

"These methods" refer to the ones added in the commit -- that seems clear to me.

They are not "methods", though (that is wrong), but apart from that, I
am not sure what the issue is with those two words.

To be clear, this does not mean the commit message is good -- I agree
that it should provide more justification.

Cheers,
Miguel