Re: [PATCH v3 6/8] PCI: dwc: pcie-qcom-ep: enable EP support for SAR2130P

From: Dmitry Baryshkov
Date: Sat Feb 22 2025 - 13:06:21 EST


On 22 February 2025 18:50:38 EET, Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxx> wrote:
>On Fri, Feb 21, 2025 at 05:52:04PM +0200, Dmitry Baryshkov wrote:
>> Enable PCIe endpoint support for the Qualcomm SAR2130P platform. It is
>> impossible to use fallback compatible to any other platform since
>> SAR2130P uses slightly different set of clocks.
>>
>
>Still, why do you want the compatible to be added to the driver? It shall be
>defined in the binding with the respective clock difference. Driver should just
>work with the fallback compatible.

Well, per my understanding (or according to my feeling) different set of clocks means that they are not completely compatible. An Ack from DT maintainers supports this.

Moreover, if we were to declare fallback, which one would you prefer?


>
>- Mani
>