Re: [PATCH v8] sched: Consolidate cpufreq updates

From: Qais Yousef
Date: Sat Feb 22 2025 - 19:04:15 EST


On 02/21/25 16:47, Ingo Molnar wrote:
>
> * Qais Yousef <qyousef@xxxxxxxxxxx> wrote:
>
> > ---
> > include/linux/sched/cpufreq.h | 4 +-
> > kernel/sched/core.c | 116 +++++++++++++++++++++++++++--
> > kernel/sched/cpufreq_schedutil.c | 122 +++++++++++++++++++------------
> > kernel/sched/deadline.c | 10 ++-
> > kernel/sched/fair.c | 84 +++++++++------------
> > kernel/sched/rt.c | 8 +-
> > kernel/sched/sched.h | 9 ++-
> > kernel/sched/syscalls.c | 30 ++++++--
> > 8 files changed, 266 insertions(+), 117 deletions(-)
>
> The changelog is rather long, and the diffstat is non-trivial.
>
> Could you please split this up into multiple patches?

Sure. I did consider that but what stopped me is that I couldn't see how
I could break them into independent patches. A lot of corner cases needed to be
addressed and if I moved them to their own patches I'd potentially break
bisectability of this code. If this is not a problem then I can see how I can
do a better split. If it is a problem, I'll still try to think it over but it
might require a bit of stretching. But I admit I didn't try to think it over
that hard.

Thanks!

--
Qais Yousef