Re: [PATCH net-next 08/13] net: phy: phy_caps: Introduce link_caps_valid

From: kernel test robot
Date: Sun Feb 23 2025 - 01:39:40 EST


Hi Maxime,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url: https://github.com/intel-lab-lkp/linux/commits/Maxime-Chevallier/net-phy-Extract-the-speed-duplex-to-linkmode-conversion-from-phylink/20250222-223310
base: net-next/main
patch link: https://lore.kernel.org/r/20250222142727.894124-9-maxime.chevallier%40bootlin.com
patch subject: [PATCH net-next 08/13] net: phy: phy_caps: Introduce link_caps_valid
config: x86_64-buildonly-randconfig-004-20250223 (https://download.01.org/0day-ci/archive/20250223/202502231409.QTfXTqrD-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250223/202502231409.QTfXTqrD-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202502231409.QTfXTqrD-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/net/phy/phy_caps.c:152: warning: Function parameter or struct member 'speed' not described in 'phy_caps_valid'
>> drivers/net/phy/phy_caps.c:152: warning: Function parameter or struct member 'duplex' not described in 'phy_caps_valid'
>> drivers/net/phy/phy_caps.c:152: warning: Function parameter or struct member 'linkmodes' not described in 'phy_caps_valid'


vim +152 drivers/net/phy/phy_caps.c

147
148 /**
149 * phy_caps_valid() - Validate a linkmodes set agains given speed and duplex
150 */
151 bool phy_caps_valid(int speed, int duplex, const unsigned long *linkmodes)
> 152 {
153 int capa = speed_duplex_to_capa(speed, duplex);
154
155 if (capa < 0)
156 return false;
157
158 return linkmode_intersects(link_caps[capa].linkmodes, linkmodes);
159 }
160

--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki