Re: [PATCH v2 1/4] dt-bindings: clock: samsung,exynos990-clock: add PERIC0/1 clock management unit

[Krzysztof Kozlowski]

On 12/02/2025 01:48, Denzeel Oliva wrote:
> Add dt-schema documentation for the Connectivity Peripheral 0 / 1
> (PERIC0/1) clock management unit.
> 
> Signed-off-by: Denzeel Oliva <wachiturroxd150@xxxxxxxxx>
> ---
>  .../clock/samsung,exynos990-clock.yaml        |  24 +++
>  include/dt-bindings/clock/samsung,exynos990.h | 176 ++++++++++++++++++
>  2 files changed, 200 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml b/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml
> index c15cc1752..dd301deda 100644
> --- a/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/samsung,exynos990-clock.yaml
> @@ -30,6 +30,8 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - samsung,exynos990-cmu-peric0
> +      - samsung,exynos990-cmu-peric1

Mismatched order.

>        - samsung,exynos990-cmu-hsi0
>        - samsung,exynos990-cmu-peris
>        - samsung,exynos990-cmu-top
> @@ -56,6 +58,28 @@ required:
>    - reg
>  
>  allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            enum:
> +              - samsung,exynos990-cmu-peric1
> +              - samsung,exynos990-cmu-peric0

These also reverse.  Keep things ordered alphabetically. Also this
if:then: block should go to appropriate place.


Best regards,
Krzysztof