Re: [PATCH v1 1/2] dt-bindings: extcon: Document Maxim MAX14526 MUIC

[Svyatoslav Ryhel]

нд, 23 лют. 2025 р. о 16:13 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
>
> On 23/02/2025 12:51, Svyatoslav Ryhel wrote:
> > нд, 23 лют. 2025 р. о 13:38 Krzysztof Kozlowski <krzk@xxxxxxxxxx> пише:
> >>
> >> On Wed, Feb 19, 2025 at 10:37:23AM +0200, Svyatoslav Ryhel wrote:
> >>> Add bindings for Maxim MAX14526 MicroUSB Integrated Circuit.
> >>>
> >>> Signed-off-by: Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> >>> ---
> >>>  .../bindings/extcon/maxim,max14526.yaml       | 46 +++++++++++++++++++
> >>>  1 file changed, 46 insertions(+)
> >>>  create mode 100644 Documentation/devicetree/bindings/extcon/maxim,max14526.yaml
> >>>
> >>> diff --git a/Documentation/devicetree/bindings/extcon/maxim,max14526.yaml b/Documentation/devicetree/bindings/extcon/maxim,max14526.yaml
> >>> new file mode 100644
> >>> index 000000000000..87cf7fd19ee9
> >>> --- /dev/null
> >>> +++ b/Documentation/devicetree/bindings/extcon/maxim,max14526.yaml
> >>> @@ -0,0 +1,46 @@
> >>> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> >>> +%YAML 1.2
> >>> +---
> >>> +$id: http://devicetree.org/schemas/extcon/maxim,max14526.yaml#
> >>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> >>> +
> >>> +title: Maxim MAX14526 MicroUSB Integrated Circuit (MUIC)
> >>> +
> >>> +maintainers:
> >>> +  - Svyatoslav Ryhel <clamor95@xxxxxxxxx>
> >>> +
> >>> +properties:
> >>> +  compatible:
> >>> +    const: maxim,max14526-muic
> >>
> >> Is it something more than muic? Why different filename than compatible?
> >>
> >
> > No it is only MUIC, nothing more. How to adjust it then?
>
> Compatible should be only "maxim,max14526".
>

Fair


> >
> >>> +
> >>> +  reg:
> >>> +    maxItems: 1
> >>> +
> >>> +  interrupts:
> >>> +    maxItems: 1
> >>
> >> This looks incomplete. Missing ports/connector.
> >>
> >
> > It does not support OF graph model. I might look into adding this
>
> You mean driver, but I mean hardware. Hardware is connected to USB
> socket one one side and to USB controller on other. At least, it might
> be more.
>

Yes, I mean driver BUT we are talking not about the extcon itself but
about an abstraction of its connections. Anyway. I can model it in
graph form, but its links do not support graph type of connection
since extcon device class framework provides only getting it by
phandle. Moreover, tegra usb controller supports extcon link only in
form of phandles. How to model this?

> > though it is just a single port.
>
>
>
>
> Best regards,
> Krzysztof