Re: [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox implementation for AF's VF

[Sai Krishna Gajula]

> -----Original Message-----
> From: Paolo Abeni <pabeni@xxxxxxxxxx>
> Sent: Thursday, February 20, 2025 5:36 PM
> To: Sai Krishna Gajula <saikrishnag@xxxxxxxxxxx>; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>;
> Geethasowjanya Akula <gakula@xxxxxxxxxxx>; Linu Cherian
> <lcherian@xxxxxxxxxxx>; Jerin Jacob <jerinj@xxxxxxxxxxx>; Hariprasad
> Kelam <hkelam@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta
> <sbhatta@xxxxxxxxxxx>; andrew+netdev@xxxxxxx; kalesh-
> anakkur.purayil@xxxxxxxxxxxx
> Subject: Re: [net-next PATCH v10 5/6] octeontx2-af: CN20K mbox
> implementation for AF's VF
> 
> On 2/17/25 9: 52 AM, Sai Krishna wrote: > @@ -61,3 +62,49 @@ irqreturn_t
> cn20k_pfaf_mbox_intr_handler(int irq, void *pf_irq) > > return
> IRQ_HANDLED; > } > + > +irqreturn_t cn20k_vfaf_mbox_intr_handler(int irq,
> void *vf_irq) 
> On 2/17/25 9:52 AM, Sai Krishna wrote:
> > @@ -61,3 +62,49 @@ irqreturn_t cn20k_pfaf_mbox_intr_handler(int irq,
> > void *pf_irq)
> >
> >  	return IRQ_HANDLED;
> >  }
> > +
> > +irqreturn_t cn20k_vfaf_mbox_intr_handler(int irq, void *vf_irq) {
> > +	struct otx2_nic *vf = vf_irq;
> > +	struct otx2_mbox_dev *mdev;
> > +	struct otx2_mbox *mbox;
> > +	struct mbox_hdr *hdr;
> > +	int vf_trig_val;
> > +
> > +	vf_trig_val = otx2_read64(vf, RVU_VF_INT) & 0x3;
> > +	/* Clear the IRQ */
> > +	otx2_write64(vf, RVU_VF_INT, vf_trig_val);
> > +
> > +	/* Read latest mbox data */
> > +	smp_rmb();
> > +
> > +	if (vf_trig_val & BIT_ULL(1)) {
> 
> `vf_trig_val` has `int` type, why are casting the mask to unsigned long long? A
> similar thing below.
Ack, will fix in V11 version. 
> 
> /P