Re: [PATCH v3 3/6] media: uvcvideo: Add a uvc_status guard
From: Laurent Pinchart
Date: Sun Feb 23 2025 - 11:07:01 EST
Hi Ricardo,
Thank you for the patch.
On Thu, Feb 06, 2025 at 07:47:02PM +0000, Ricardo Ribalda wrote:
> It helps will help will the error handling of PM functions.
This is a one-liner without a user. Bundle it with the patch that makes
use of the feature, the result will be easier to review.
> Signed-off-by: Ricardo Ribalda <ribalda@xxxxxxxxxxxx>
> ---
> drivers/media/usb/uvc/uvcvideo.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/media/usb/uvc/uvcvideo.h b/drivers/media/usb/uvc/uvcvideo.h
> index bc87e1f2c669..be0817da538c 100644
> --- a/drivers/media/usb/uvc/uvcvideo.h
> +++ b/drivers/media/usb/uvc/uvcvideo.h
> @@ -763,6 +763,8 @@ void uvc_status_suspend(struct uvc_device *dev);
> int uvc_status_get(struct uvc_device *dev);
> void uvc_status_put(struct uvc_device *dev);
>
> +DEFINE_GUARD(uvc_status, struct uvc_device *, uvc_status_get(_T), uvc_status_put(_T))
> +
> /* Controls */
> extern const struct v4l2_subscribed_event_ops uvc_ctrl_sub_ev_ops;
>
--
Regards,
Laurent Pinchart