Re: [PATCH v2 02/18] media: dt-bindings: renesas,rzg2l-csi2: Document Renesas RZ/G3E CSI-2 block
From: Tommaso Merciai
Date: Mon Feb 24 2025 - 03:12:36 EST
Hi Laurent, Prabhakar,
Thanks for the review.
On Sun, Feb 23, 2025 at 09:11:47PM +0000, Lad, Prabhakar wrote:
> Hi Tommaso,
>
> Thank you for the patch.
>
> On Fri, Feb 21, 2025 at 4:04 PM Tommaso Merciai
> <tommaso.merciai.xr@xxxxxxxxxxxxxx> wrote:
> >
> > Document the CSI-2 block which is part of CRU found in Renesas RZ/G3E
> > SoC.
> >
> > The CSI-2 block on the RZ/G3E SoC is identical to one found on the
> > RZ/V2H(P) SoC.
> >
> > Signed-off-by: Tommaso Merciai <tommaso.merciai.xr@xxxxxxxxxxxxxx>
> > ---
> > .../devicetree/bindings/media/renesas,rzg2l-csi2.yaml | 3 +++
> > 1 file changed, 3 insertions(+)
> >
> As pointed by Laurent, with below added to resets description,
>
> - description:
> CRU_CMN_RSTB reset terminal (except for RZ/V2H(P) and RZ/G3E) or
> D-PHY reset (for RZ/V2H(P) and RZ/G3E).
>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
Will apply this in v3.
Thanks.
Regards,
Tommaso
>
> Cheers,
> Prabhakar
>
>
> > diff --git a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > index 1d7784e8af16..9b7ed86ef14b 100644
> > --- a/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > +++ b/Documentation/devicetree/bindings/media/renesas,rzg2l-csi2.yaml
> > @@ -24,6 +24,9 @@ properties:
> > - renesas,r9a07g044-csi2 # RZ/G2{L,LC}
> > - renesas,r9a07g054-csi2 # RZ/V2L
> > - const: renesas,rzg2l-csi2
> > + - items:
> > + - const: renesas,r9a09g047-csi2 # RZ/G3E
> > + - const: renesas,r9a09g057-csi2
> > - const: renesas,r9a09g057-csi2 # RZ/V2H(P)
> >
> > reg:
> > --
> > 2.34.1
> >
> >