Re: [PATCH v6 2/2] arm64: dts: rockchip: Add rk3576 pcie nodes

From: Krzysztof Kozlowski
Date: Mon Feb 24 2025 - 04:43:17 EST


On 24/02/2025 08:49, Kever Yang wrote:
> rk3576 has two pcie controllers, both are pcie2x1 work with
> naneng-combphy.
>
> Signed-off-by: Kever Yang <kever.yang@xxxxxxxxxxxxxx>
> ---
>
> Changes in v6: None
> Changes in v5: None
> Changes in v4: None
> Changes in v3:
> - Update the subject
>
> Changes in v2:
> - Update clock and reset names and sequence to pass DTB check
>
> arch/arm64/boot/dts/rockchip/rk3576.dtsi | 109 +++++++++++++++++++++++
> 1 file changed, 109 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3576.dtsi b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> index 4dde954043ef..b4f396421686 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3576.dtsi
> @@ -1127,6 +1127,115 @@ qos_npu_m1ro: qos@27f22100 {
> reg = <0x0 0x27f22100 0x0 0x20>;
> };
>
> + pcie0: pcie@2a200000 {
> + compatible = "rockchip,rk3576-pcie", "rockchip,rk3568-pcie";
> + #address-cells = <3>;
> + #size-cells = <2>;


Follow DTS coding style.

In case you respond to above after 2 months, like you do for other
patches: don't know, follow the DTS coding style.

Best regards,
Krzysztof