Re: [PATCH v9 01/13] rust: hrtimer: introduce hrtimer support

From: Boqun Feng
Date: Mon Feb 24 2025 - 11:33:16 EST


On Mon, Feb 24, 2025 at 05:23:59PM +0100, Miguel Ojeda wrote:
> On Mon, Feb 24, 2025 at 4:46 PM Boqun Feng <boqun.feng@xxxxxxxxx> wrote:
> >
> > Why do we need this new kconfig?
>
> I suspect it is to provide flexibility (i.e. to avoid building
> everything if there are no users of the abstraction) and/or to limit
> the set of configs that may be affected by a breaking change on the C
> side -- Andreas and I discussed it the other day. The description of
> the issue has some lines, but perhaps the commit message could

Do you have a link to the issue?

I asked because hrtimer API is always available regardless of the
configuration, and it's such a core API, so it should always be there
(Rust or C).

Regards,
Boqun

> clarify.
>
> We have a similar one already, i.e. a "Rust-only" config, in
> `CONFIG_RUST_FW_LOADER_ABSTRACTIONS`.
>
> Since this one is default "y", it may still affect unrelated
> subsystems that just enable `RUST=y`, though.
>
> (I guess we could consider `select`ing from end users. But they cannot
> be hidden symbols, because that limits the control too much (e.g.
> someone may want to just build the abstraction), and in general they
> may have dependencies, so it may not be a good idea.)
>
> Cheers,
> Miguel