Re: [PATCH net-next v5 9/9] selftests: ncdevmem: Implement devmem TCP TX
From: Stanislav Fomichev
Date: Mon Feb 24 2025 - 12:54:30 EST
On 02/24, Mina Almasry wrote:
> On Mon, Feb 24, 2025 at 9:15 AM Stanislav Fomichev <stfomichev@xxxxxxxxx> wrote:
> >
> > On 02/22, Mina Almasry wrote:
> > > Add support for devmem TX in ncdevmem.
> > >
> > > This is a combination of the ncdevmem from the devmem TCP series RFCv1
> > > which included the TX path, and work by Stan to include the netlink API
> > > and refactored on top of his generic memory_provider support.
> > >
> > > Signed-off-by: Mina Almasry <almasrymina@xxxxxxxxxx>
> > > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>
> >
> > Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>
> >
> > We need exit_wait=True for check_rx as well, but I'll send this change
> > separately.
>
> Yes, I discovered the same thing, and I have that change locally along
> with some other fix ups I'm readying up for review in a separate
> series.
Perfect, then I'll wait for you to address it separately!