Re: [PATCH] ceph: osd_client deadcode

From: Viacheslav Dubeyko
Date: Mon Feb 24 2025 - 14:56:01 EST


On Sat, 2025-02-22 at 01:35 +0000, linux@xxxxxxxxxxx wrote:
> From: "Dr. David Alan Gilbert" <linux@xxxxxxxxxxx>
>
> osd_req_op_extent_osd_data_pagelist() was added in 2013 as part of
> commit a4ce40a9a7c1 ("libceph: combine initializing and setting osd data")
> but never used.
>
> The last use of osd_req_op_cls_request_data_pagelist() was removed in
> 2017's
> commit ecd4a68a26a2 ("rbd: switch rbd_obj_method_sync() to
> ceph_osdc_call()")
>
> Remove them.
>

If we don't use these methods, then it makes sense to remove it. We can take
them back in the case of real necessity in this functionality.

Reviewed-by: Viacheslav Dubeyko <Slava.Dubeyko@xxxxxxx>

Thanks,
Slava.