Re: [PATCH v3 0/8] Add io_dir to avoid memory overhead from opendir
From: Namhyung Kim
Date: Mon Feb 24 2025 - 19:30:32 EST
On Mon, Feb 24, 2025 at 04:28:24PM -0800, Namhyung Kim wrote:
> Hi Ian,
>
> On Fri, Feb 21, 2025 at 10:10:05PM -0800, Ian Rogers wrote:
> > glibc's opendir allocates a minimum of 32kb, when called recursively
> > for a directory tree the memory consumption can add up - nearly 300kb
> > during perf start-up when processing modules. Add a stack allocated
> > variant of readdir sized a little more than 1kb
>
> It's still small and hard to verify. I've run the following command
> before and after the change but didn't see a difference.
>
> $ sudo time -f %Mk ./perf record -a true
> [ perf record: Woken up 1 times to write data ]
> [ perf record: Captured and wrote 1.757 MB perf.data (563 samples) ]
> 74724k
>
> According to man time(1), %M is for max RSS.
But anyway, it looks ok and build is fine now.
Thanks,
Namhyung