[PATCH scripts] scripts/sorttable: Fix resource leak in parse_symbols()
From: Dheeraj Reddy Jonnalagadda
Date: Tue Feb 25 2025 - 00:37:43 EST
Fix a resource leak in parse_symbols() where the file pointer fp
was not closed if add_field() returned an error. This caused an
open file descriptor to remain unclosed. Ensure that fp is properly
closed before returning an error.
Fixes: ef378c3b8233 ("scripts/sorttable: Zero out weak functions in mcount_loc table")
Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@xxxxxxxxx>
---
scripts/sorttable.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/scripts/sorttable.c b/scripts/sorttable.c
index 23c7e0e6c024..b9b066c1afee 100644
--- a/scripts/sorttable.c
+++ b/scripts/sorttable.c
@@ -662,8 +662,10 @@ static int parse_symbols(const char *fname)
addr = strtoull(addr_str, NULL, 16);
size = strtoull(size_str, NULL, 16);
- if (add_field(addr, size) < 0)
+ if (add_field(addr, size) < 0) {
+ fclose(fp);
return -1;
+ }
}
fclose(fp);
--
2.34.1