Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic mbox operations and structures

[Sai Krishna Gajula]

> -----Original Message-----
> From: Paolo Abeni <pabeni@xxxxxxxxxx>
> Sent: Thursday, February 20, 2025 5:20 PM
> To: Sai Krishna Gajula <saikrishnag@xxxxxxxxxxx>; davem@xxxxxxxxxxxxx;
> edumazet@xxxxxxxxxx; kuba@xxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Sunil Kovvuri Goutham <sgoutham@xxxxxxxxxxx>;
> Geethasowjanya Akula <gakula@xxxxxxxxxxx>; Linu Cherian
> <lcherian@xxxxxxxxxxx>; Jerin Jacob <jerinj@xxxxxxxxxxx>; Hariprasad Kelam
> <hkelam@xxxxxxxxxxx>; Subbaraya Sundeep Bhatta <sbhatta@xxxxxxxxxxx>;
> andrew+netdev@xxxxxxx; kalesh-anakkur.purayil@xxxxxxxxxxxx
> Subject: Re: [net-next PATCH v10 2/6] octeontx2-af: CN20k basic
> mbox operations and structures
> 
> On 2/17/25 9: 52 AM, Sai Krishna wrote: > @@ -2443,6 +2469,18 @@ static
> int rvu_mbox_init(struct rvu *rvu, struct mbox_wq_info *mw, > } > } > > +
> ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL); > + if
> (!ng_rvu_mbox) 
> On 2/17/25 9:52 AM, Sai Krishna wrote:
> > @@ -2443,6 +2469,18 @@ static int rvu_mbox_init(struct rvu *rvu, struct
> mbox_wq_info *mw,
> >  		}
> >  	}
> >
> > +	ng_rvu_mbox = kzalloc(sizeof(*ng_rvu_mbox), GFP_KERNEL);
> > +	if (!ng_rvu_mbox) {
> > +		err = -ENOMEM;
> > +		goto free_bitmap;
> > +	}
> > +
> > +	rvu->ng_rvu = ng_rvu_mbox
> 
> AFAICS rvu->ng_rvu is freed only by rvu_remove(), so it's leaked on the later
> error paths.
Ack, will submit v11 with updates.
> 
> /P