RE: [PATCH v2 06/12] iommu/vt-d: Cleanup intel_context_flush_present()
From: Tian, Kevin
Date: Tue Feb 25 2025 - 02:43:28 EST
> From: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> Sent: Monday, February 24, 2025 1:16 PM
>
> The intel_context_flush_present() is called in places where either the
> scalable mode is disabled, or scalable mode is enabled but all PASID
> entries are known to be non-present. In these cases, the flush_domains
> path within intel_context_flush_present() will never execute. This dead
> code is therefore removed.
>
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
usually a suffix "_present()" indicates that the helper can be called
on an object which is currently in-use, which is obviously not the
case here.
To avoid confusion probably just call it intel_context_flush() or
intel_context_flush_no_user() is clearer.
Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>