Re: [PATCH net v2 0/2] Fixes for perout configuration in IEP driver

[Malladi, Meghana]

On 2/21/2025 6:54 AM, Jakub Kicinski wrote:
> On Wed, 19 Feb 2025 15:37:16 -0800 Jacob Keller wrote:
> > On 2/18/2025 10:26 PM, Meghana Malladi wrote:
> > > IEP driver supports both pps and perout signal generation using testptp
> > > application. Currently the driver is missing to incorporate the perout
> > > signal configuration. This series introduces fixes in the driver to
> > > configure perout signal based on the arguments passed by the perout
> > > request.
> > >    
> >
> > This could be interpreted as a feature implementation rather than a fix.
> >
> > Reviewed-by: Jacob Keller <jacob.e.keller@xxxxxxxxx>
>
> Agreed, ideally we should get a patch for net which rejects
> all currently (as in - in Linus's tree) unsupported settings.
> That would be a fix.
>
> Then once that's merged add support for the new settings in net-next.
>
> Hope that makes sense?

I do agree that this can be interpreted as a feature implementation (as 
the bug here is: missing perout driver implementation for which the 
driver claims it supports). I will post the updated patch series as 
suggested by Jakub.

Thanks,
Meghana Malladi.