Re: [PATCH] rust: miscdevice: change how f_ops vtable is constructed

[Greg Kroah-Hartman]

On Tue, Feb 25, 2025 at 11:10:17AM +0100, Alice Ryhl wrote:
> On Wed, Feb 19, 2025 at 4:58 PM Greg Kroah-Hartman
> <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> >
> > On Fri, Jan 17, 2025 at 02:22:32PM +0000, Alice Ryhl wrote:
> > > I was helping someone with writing a new Rust abstraction, and we were
> > > using the miscdevice abstraction as an example. While doing this, it
> > > became clear to me that the way I implemented the f_ops vtable is
> > > confusing to new Rust users, and that the approach used by the block
> > > abstractions is less confusing.
> > >
> > > Thus, update the miscdevice abstractions to use the same approach as
> > > rust/kernel/block/mq/operations.rs.
> > >
> > > Sorry about the large diff. This changes the indentation of a large
> > > amount of code.
> > >
> > > Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>
> > > ---
> > >  rust/kernel/miscdevice.rs | 295 ++++++++++++++++++++++------------------------
> > >  1 file changed, 141 insertions(+), 154 deletions(-)
> >
> > This doesn't apply against a clean 6.14-rc2 tree, what is is made
> > against?
> 
> I will rebase.
> 
> Are there any other miscdevice commits that have landed this cycle
> that it might conflict with? If so, I can base it on your branch to
> avoid such conflicts.

Nope, I don't see any at the moment, or in my review queue, so it should
be fine.

thanks,

greg k-h