Re: [Patch v2 11/24] perf/x86/intel: Factor out common functions to process PEBS groups

From: Peter Zijlstra
Date: Tue Feb 25 2025 - 06:05:17 EST


On Tue, Feb 18, 2025 at 03:28:05PM +0000, Dapeng Mi wrote:
> Adaptive PEBS and arch-PEBS share lots of same code to process these
> PEBS groups, like basic, GPR and meminfo groups. Extract these shared
> code to common functions to avoid duplicated code.

Should you not flip this and the previous patch? Because afaict you're
mostly removing the code you just added, which is a bit silly.