Re: linux-next: Fixes tag needs some work in the vhost tree
From: Michael S. Tsirkin
Date: Tue Feb 25 2025 - 07:15:29 EST
On Tue, Feb 25, 2025 at 09:45:50AM +1100, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
> b995427e8a85 ("tools: virtio/linux/module.h add MODULE_DESCRIPTION() define.")
>
> Fixes tag
>
> Fixes: <ab0727f3ddb8>("virtio: add missing MODULE_DESCRIPTION() macros")
>
> has these problem(s):
>
> - No SHA1 recognised
>
> In commit
>
> 9709a9145ffe ("tools/virtio: Add DMA_MAPPING_ERROR and sg_dma_len api define for virtio test")
>
> Fixes tag
>
> Fixes: <c7e1b422afac>("virtio_ring: perform premapped operations based on per-buffer")
>
> has these problem(s):
>
> - No SHA1 recognised
>
> Fixes tags should be
>
> Fixes: SHA1 ("subject")
>
> Also, please keep all the commit message tags together at the end of
> the commit message.
Yep. Thanks, fixed up. Yufeng Wang, pls take a look at my fixup -
both to check them and to make sure to follow this example
in the future.
> --
> Cheers,
> Stephen Rothwell