Re: [PATCH sched_ext/for-6.14-fixes] sched_ext: Fix pick_task_scx() picking non-queued tasks when it's called without balance()
From: Tejun Heo
Date: Tue Feb 25 2025 - 12:51:52 EST
On Tue, Feb 25, 2025 at 06:14:15PM +0100, Andrea Righi wrote:
> > Fix it by testing whether @prev has SCX_TASK_QUEUED set. This makes
> > $prev_on_scx only used in one place. Open code the usage and improve the
>
> nit: @prev_on_scx?
Yeah, I don't know. Some people use @ only for arguments and $ for
variables. Others always use @. I flip flop between them.
Thanks.
--
tejun