Re: [PATCH] Improved hfsplus in the kernel

[Al Viro]

On Wed, Feb 26, 2025 at 02:00:36AM +0530, Pranjal Prasad wrote:
> Hi,
> 
> Please find attached the patch to improve the HFS+ filesystem support in the
> kernel. I have not done much work, but as I require HFS, HFS+, and APFS in
> Linux, I decided to maintain it. Please allow me to be the maintainer of HFS
> and HFS+ in the kernel.

Umm...  "Improved" is not a description - it's marketdroidese.
And comments are supposed to help understanding why we are doing
something, not retelling what's being done in every line.
Being more verbose is no virtue - not when it adds no information.

What's more worrying, though...  are there actual changes in
that pile of added comments?  Your "improved and added comments"
would seem to imply that these had been two distinct things,
so it sounds like there are actual modifications involved.

In such case you really should separate those rather than
burying them.

And this "every line must come with a comment, no matter how useful it is"
is a habit best unlearnt.  I realize that a bunch of places teach that,
but it's a really, really bad idea.