Re: [PATCH] x86/CPU: Fix warm boot hang regression on AMD SC1100 SoC systems

[Russell Senior]

On Tue, Feb 25, 2025 at 1:42 PM Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
>
> * Russell Senior <russell@xxxxxxxxxxxxxxxxx> wrote:
>
> > More poking/prodding and coaching from Jonas Gorski (cc'd), it looks
> > like this test patch fixes the problem on my board: Tested against
> > v6.6.67 and v4.14.113:
> >
> > --- a/arch/x86/kernel/cpu/cyrix.c
> > +++ b/arch/x86/kernel/cpu/cyrix.c
> > @@ -153,8 +153,8 @@ static void geode_configure(void)
> >         u8 ccr3;
> >         local_irq_save(flags);
> >
> > -       /* Suspend on halt power saving and enable #SUSP pin */
> > -       setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x88);
> > +       /* Suspend on halt power saving */
> > +       setCx86(CX86_CCR2, getCx86(CX86_CCR2) | 0x08);
> >
> >         ccr3 = getCx86(CX86_CCR3);
> >         setCx86(CX86_CCR3, (ccr3 & 0x0f) | 0x10);       /* enable MAPEN */
>
> That's really useful - thank you!
>
> I've constructed a fix patch from your mails, attached below. I added
> your Signed-off-by to the fix, let me know if that's OK with you.

That's OK with me.

>
> I have applied your fix to the x86 tree, if everything goes fine it
> ought to go upstream during the next merge window in ~4 weeks, with
> v6.15.
>
> Thanks,
>
>         Ingo
>

Thank you!

-- 
Russell Senior
russell@xxxxxxxxxxxxxxxxx