Re: [PATCH v4 2/3] irqchip: Add the Sophgo SG2042 MSI interrupt controller

[Chen Wang]

On 2025/2/21 14:35, Inochi Amaoto wrote:
[......]
> > +static int sg2042_msi_init_domains(struct sg2042_msi_chipdata *data,
> > +				   struct device *dev)
> > +{
> > +	struct fwnode_handle *fwnode = dev_fwnode(dev);
> > +	struct irq_domain *plic_domain, *middle_domain;
> > +	struct fwnode_handle *plic_node;
> > +
> > +	plic_node = fwnode_find_reference(fwnode, "msi-ranges", 0);
> > +	if (IS_ERR(plic_node)) {
> > +		pr_err("Failed to find the PLIC node!\n");
> > +		return PTR_ERR(plic_node);
> > +	}
> I think plic_node is just the args.fwnode in the sg2042_msi_probe.
> Just reuse it. No need to parse this again.
>
> Otherwise, It looks good to me. With this fix:
>
> Reviewed-by: Inochi Amaoto <inochiama@xxxxxxxxx>

Thanks, I will fix this.

Regards,

Chen

[......]