RE: [PATCH 1/2] dt-bindings: regulator: add adi,adp5055-regulator

[Torreno, Alexis Czezar]

> -----Original Message-----
> From: Mark Brown <broonie@xxxxxxxxxx>
> Sent: Tuesday, February 25, 2025 10:07 PM
> To: Torreno, Alexis Czezar <AlexisCzezar.Torreno@xxxxxxxxxx>
> Cc: Liam Girdwood <lgirdwood@xxxxxxxxx>; Rob Herring <robh@xxxxxxxxxx>;
> Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>; Conor Dooley
> <conor+dt@xxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx;
> devicetree@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] dt-bindings: regulator: add adi,adp5055-regulator
> 
> [External]
> 
> On Tue, Feb 25, 2025 at 05:08:33PM +0800, Alexis Czezar Torreno wrote:
> 
> > +      adi,power-saving-mode:
> > +        description:
> > +          If present, enables power saving mode for
> > +          individual channels.
> > +        type: boolean
> 
> We have standard mode operations, please implement those.

Will implement

> 
> > +      adi,output-discharge-function:
> > +        description:
> > +          If present, enable output discharge functionality
> > +          for individual channels.
> > +        type: boolean
> 
> set_active_discharge()

Will implement

> 
> > +      adi,disable-delay-us:
> > +        description:
> > +          Configures the disable delay for each channel. Dependent on Tset.
> > +        enum: [0, 5200, 10400, 15600, 20800, 26000, 31200, 36400]
> > +        default: 0
> > +
> > +      adi,enable-delay-us:
> > +        description:
> > +          Configures the disable delay for each channel. Dependent on Tset.
> > +        enum: [0, 2600, 5200, 7800, 10400, 13000, 15600, 18200]
> > +        default: 0
> 
> This looks a lot like the driver should implemnt the enable_time() and/or
> set_ramp_delay() operations and use the constraints to configure this.

Based on what I understand I agree implementing the enable_time() core
function for this. However, shall I keep the code for the disable-delay-us?
I don't think I saw a disable_time() equivalent