Re: [PATCH 1/2] x86/bootflag: Change some static functions to bool

From: Jiri Slaby
Date: Wed Feb 26 2025 - 01:31:47 EST


On 24. 02. 25, 19:58, Ingo Molnar wrote:
So this CodingStyle entry is a red herring, and the !! is absolutely
used in the kernel

Sure, for intended conversion to either 0 or 1.

as an explicit marker of intentional type conversion
to bool.

With this in mind, you would have to write "if (!!x)" everywhere.

I don't want such constructions in code I maintain. (Nor for return values.) But this is not code I maintain (obviously), so your call after all.

thanks,
--
js
suse labs