Re: [PATCH 2/2] PCI: dwc-debugfs: Return -EOPNOTSUPP if an event counter is not supported
From: Krzysztof Wilczyński
Date: Wed Feb 26 2025 - 01:57:05 EST
Hello,
> If the platform doesn't support an event counter, enabling it using the
> 'counter_enable' debugfs attribute currently will succeed. But reading the
> debugfs attribute back will return 'Counter Disabled'.
>
> This could cause confusion to the users. So while enabling an event
> counter in counter_enable_write(), always read back the status to check if
> the counter is enabled or not. If not, return -EOPNOTSUPP to let the users
> know that the event counter is not supported.
Thank you for following up on this. Appreciated. With that...
Reviewed-by: Krzysztof Wilczyński <kwilczynski@xxxxxxxxxx>
Thank you!
Krzysztof