Re: [PATCH v1 3/4] pps: generators: tio: Introduce Intel Elkhart Lake PSE TIO

From: Andy Shevchenko
Date: Wed Feb 26 2025 - 08:01:25 EST


On Wed, Feb 26, 2025 at 11:45:26AM +0530, Raag Jadav wrote:
> Add initial support for Intel Elkhart Lake PSE TIO controller.

...

> +static const struct pps_tio_data ehl_pse_data = {
> + .regs = {
> + .ctl = TIOCTL_PSE,
> + .compv = TIOCOMPV_PSE,
> + .ec = TIOEC_PSE,
> + },
> +};

Same as previous comment, please move it further in the code closer to the ID
table which is the user of this data.

--
With Best Regards,
Andy Shevchenko