Re: [PATCH net v2] net: Handle napi_schedule() calls from non-interrupt

From: Eric Dumazet
Date: Wed Feb 26 2025 - 08:35:03 EST


On Wed, Feb 26, 2025 at 2:21 PM Frederic Weisbecker <frederic@xxxxxxxxxx> wrote:
>

> That looks good and looks like what I did initially:
>
> https://lore.kernel.org/lkml/20250212174329.53793-2-frederic@xxxxxxxxxx/
>
> Do you prefer me doing it over DEBUG_NET_WARN_ON_ONCE() or with lockdep
> like in the link?

To be clear, I have not tried this thing yet.

Perhaps let your patch as is (for stable backports), and put the debug
stuff only after some tests, in net-next.

It is very possible that napi_schedule() in the problematic cases were
not on a fast path anyway.

Reviewed-by: Eric Dumazet <edumazet@xxxxxxxxxx>