Re: [PATCH v1] drm/ci: fix merge request rules

[Vignesh Raman]

Hi Daniel,

On 26/02/25 19:29, Daniel Stone wrote:
> Hi Vignesh,
>
> On Wed, 26 Feb 2025 at 13:55, Vignesh Raman <vignesh.raman@xxxxxxxxxxxxx> wrote:
> > Merge request pipelines were only created when changes
> > were made to drivers/gpu/drm/ci/, causing MRs that didn't
> > touch this path to break. Fix MR pipeline rules to trigger
> > jobs for all changes.
>
> Thanks a lot for fixing this up!
>
> >       # Build everything after someone bypassed the CI
> >       - if: *is-direct-push
> >         when: on_success
>
> Should these be when: manual? I think it would be good to align with
> the rules we have for Mesa: run automatically for marge-bot and also
> for scheduled pipelines, but in all other cases (MR context but not
> scheduled for merge, direct push to ref, etc) be manual, so we don't
> overwhelm the CI by testing everything everyone pushed.

mesa has on_success for is-direct-push. Should we change it to manual 
here and update the same in mesa ?

If a user creates a MR, should the jobs run automatically, since we do 
not use marge-bot to merge MRs in drm?

I also noticed we need to remove reference to mesa 
(CI_PROJECT_NAMESPACE). I will send v2 with this change.

Regards,
Vignesh

> Cheers,
> Daniel