Re: [PATCH net-next] net: sfp: add quirk for FS SFP-10GM-T copper SFP+ module

[Martin Schiller]

On 2025-02-26 17:27, Kory Maincent wrote:
> On Wed, 26 Feb 2025 16:55:38 +0100
> Martin Schiller <ms@xxxxxxxxxx> wrote:
>
> > On 2025-02-26 16:26, Kory Maincent wrote:
> > > On Wed, 26 Feb 2025 15:50:46 +0100
> > > Martin Schiller <ms@xxxxxxxxxx> wrote:
> > >
> > >> On 2025-02-26 15:38, Russell King (Oracle) wrote:
> >  [...]
> >  [...]
> >  [...]
> > >>
> > >> OK, I'll rename it to sfp_fixup_rollball_wait.
> > >
> > > I would prefer sfp_fixup_fs_rollball_wait to keep the name of the
> > > manufacturer.
> > > It can't be a generic fixup as other FSP could have other waiting time
> > > values
> > > like the Turris RTSFP-10G which needs 25s.
> >
> > I think you're getting two things mixed up.
> > The phy still has 25 seconds to wake up. With sfp_fixup_rollball_wait
> > there simply is an additional 4s wait at the beginning before we start
> > searching for a phy.
>
> Indeed you are right, I was looking in older Linux sources, sorry.
> Still, the additional 4s wait seems relevant only for FS SFP, so it 
> should
> be included in the function naming to avoid confusion.

You may be right for the moment. But perhaps there will soon be SFP
modules from other manufacturers that also need this quirk.

There is also the function sfp_fixup_rollball_cc, which is currently
only used for modules with vendor string “OEM”. However, the function is
not called sfp_fixup_oem_rollball_cc.

Regards,
Martin