Re: [PATCH net-next] net: sfp: add quirk for FS SFP-10GM-T copper SFP+ module

[Kory Maincent]

On Wed, 26 Feb 2025 17:51:42 +0100
Martin Schiller <ms@xxxxxxxxxx> wrote:

> On 2025-02-26 17:27, Kory Maincent wrote:
> > On Wed, 26 Feb 2025 16:55:38 +0100
> > Martin Schiller <ms@xxxxxxxxxx> wrote:
> >   
> >> On 2025-02-26 16:26, Kory Maincent wrote:  
>  [...]  
>  [...]  
> >>  [...]
> >>  [...]
> >>  [...]  
>  [...]  
>  [...]  
> >> 
> >> I think you're getting two things mixed up.
> >> The phy still has 25 seconds to wake up. With sfp_fixup_rollball_wait
> >> there simply is an additional 4s wait at the beginning before we start
> >> searching for a phy.  
> > 
> > Indeed you are right, I was looking in older Linux sources, sorry.
> > Still, the additional 4s wait seems relevant only for FS SFP, so it 
> > should
> > be included in the function naming to avoid confusion.
> >   
> 
> You may be right for the moment. But perhaps there will soon be SFP
> modules from other manufacturers that also need this quirk.
> 
> There is also the function sfp_fixup_rollball_cc, which is currently
> only used for modules with vendor string “OEM”. However, the function is
> not called sfp_fixup_oem_rollball_cc.

Indeed. As you prefer then.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com