Re: [PATCH 4/6] x86/microcode/intel_staging: Implement staging logic

From: Borislav Petkov
Date: Wed Feb 26 2025 - 12:58:39 EST


On Tue, Dec 10, 2024 at 05:42:10PM -0800, Chang S. Bae wrote:
> diff --git a/arch/x86/kernel/cpu/microcode/Makefile b/arch/x86/kernel/cpu/microcode/Makefile
> index 193d98b33a0a..a9f79aaffcb0 100644
> --- a/arch/x86/kernel/cpu/microcode/Makefile
> +++ b/arch/x86/kernel/cpu/microcode/Makefile
> @@ -1,5 +1,5 @@
> # SPDX-License-Identifier: GPL-2.0-only
> microcode-y := core.o
> obj-$(CONFIG_MICROCODE) += microcode.o
> -microcode-$(CONFIG_CPU_SUP_INTEL) += intel.o
> +microcode-$(CONFIG_CPU_SUP_INTEL) += intel.o intel_staging.o
^^^^^^^^^^^^^^^

No need for that guy - just stick everything in intel.c

> +enum ucode_state do_stage(u64 pa, void *ucode_ptr, unsigned int totalsize)

static

--
Regards/Gruss,
Boris.

https://people.kernel.org/tglx/notes-about-netiquette