Re: [RFC PATCH] x86 / hibernate: Eliminate the redundant smp_ops.play_dead assignment
From: Wentao Guan
Date: Wed Feb 26 2025 - 13:12:18 EST
Hello,
Thanks for your reply.
In my opinion, the only logic different before the patch is delete smp_ops.play_dead
save and restore, as the comment "the resumed kernel will decide itself" and same
logic as which in arch/arm64/kernel/hibernate.c, the ok path will work as expect.
When discussing the error path and ret value that we not restore play_dead,
I will try to analyze the difference between native_play_dead and resume_play_dead,
and sev_es_play_dead [the all possiable three value], and I see some mwait and hlt
way difference.[maybe it happens as disable the cpu failed and goes to Enable_cpus
path in func:resume_target_kernel in hibernate.c? ] Is that it desgin to do and we can
move it to a common place in hibernate.c and left some comments ?
BRs
Wentao Guan