Re: [PATCH v4 09/10] dt-bindings: PCI: qcom,pcie-sc7280: Add 'global' interrupt

[Krzysztof Kozlowski]

On 26/02/2025 17:29, Bjorn Andersson wrote:
>>> @@ -54,7 +54,7 @@ properties:
>>>  
>>>    interrupts:
>>>      minItems: 8
>>> -    maxItems: 8
>>> +    maxItems: 9
>>>  
>>>    interrupt-names:
>>>      items:
>>> @@ -66,6 +66,7 @@ properties:
>>>        - const: msi5
>>>        - const: msi6
>>>        - const: msi7
>>> +      - const: global
>>
>> Either context is missing or these are not synced with interrupts.
>>
> 
> I think the patch context ("properties") is confusing here, but it looks
> to me that these are in sync: interrupts is defined to have 8 items, and
> interrupt-names is a list of msi0 through msi7.

interrupt-names has minItems 9 in this case, so they are not synced.
That's my concern


Best regards,
Krzysztof