Re: [PATCH v1 4/4] mfd: intel-ehl: Introduce Intel Elkhart Lake PSE GPIO and TIO

From: Raag Jadav
Date: Thu Feb 27 2025 - 00:13:48 EST


On Wed, Feb 26, 2025 at 03:22:24PM +0200, Andy Shevchenko wrote:
> On Wed, Feb 26, 2025 at 03:20:35PM +0200, Andy Shevchenko wrote:
> > On Wed, Feb 26, 2025 at 11:45:27AM +0530, Raag Jadav wrote:
>
> ...
>
> > > +++ b/drivers/mfd/intel-ehl-gpio.c
> >
> > We are usually align the file name and Kconfig option, and I like Kconfig
> > choice, so intel_ehl_pse_gpio.c (also note the style with other intel_$SOC_*
> > files in the folder.

More than 3 words is a bit of an overstretch, no?

> And also Subject, you have currently 3 different names for the same:
> Kconfig, Subject, filename.

Yeah just trying to dial down the acronym syndrome, you know how it has
plagued our minds.

Raag