Re: [PATCH 3/7] dt-bindings: thermal: r9a09g047-tsu: Document the TSU unit

[Geert Uytterhoeven]

Hi John,

On Wed, 26 Feb 2025 at 16:40, John Madieu <john.madieu.xa@xxxxxxxxxxxxxx> wrote:
> > -----Original Message-----
> > From: Rob Herring <robh@xxxxxxxxxx>
> > Sent: Thursday, February 20, 2025 8:17 PM
> > Subject: Re: [PATCH 3/7] dt-bindings: thermal: r9a09g047-tsu: Document the
> > TSU unit
> >
> > On Thu, Feb 20, 2025 at 04:26:08PM +0100, John Madieu wrote:
> > > The Renesas RZ/G3E SoC includes a Thermal Sensor Unit (TSU) block
> > > designed to measure the junction temperature. The device provides
> > > real-time temperature measurements for thermal management, utilizing a
> > > single dedicated channel (channel 1) for temperature sensing.
> > >
> > > Signed-off-by: John Madieu <john.madieu.xa@xxxxxxxxxxxxxx>
> > > ---
> > >  .../thermal/renesas,r9a09g047-tsu.yaml        | 123 ++++++++++++++++++
> > >  1 file changed, 123 insertions(+)
> > >  create mode 100644
> > > Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
> > >
> > > diff --git
> > > a/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
> > > b/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.yaml
> > > new file mode 100644
> > > index 000000000000..dbd3860a31d0
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/thermal/renesas,r9a09g047-tsu.
> > > +++ yaml

> > > +  interrupts:
> > > +    description: |
> > > +      Interrupt specifiers for the TSU:
> > > +      - S12TSUADI1: Conversion complete interrupt signal (pulse)
> > > +      - S12TSUADCMPI1: Comparison result interrupt signal (level)
> > > +
> > > +  interrupt-names:
> > > +    items:
> > > +      - const: S12TSUADI1
> > > +      - const: S12TSUADCMPI1
> >
> > Odd names for the interrupts... 'S12TSUAD' is the same for both, so that
> > part is redundant from my perspective. I guess if these strings are
> > meaningful for anyone familiar with this h/w, then it's fine.
>
> These names come from HW manual. I can change them into "conv"
> (for conversion complete irq)  and "cmp" (for comparison
> complete irq). What do you think ?

These are the names from the point of view of the interrupt controller
(Section 4.6 Interrupt Controller Table 4.6-24 List of Input Events).
The silly "1" suffix does seem have a meaning here, as S12TSUADI0
seems to be a DMAC request signal...

For the TSU bindings, we want the names from the point of view of the
TSU.  Section 7.11 Temperature Sensor Unit (TSU) Table 7.11-3 List
of Internal I/O Pins lists:
  - S12TSUADI: Conversion complete interrupt signal (pulse)
  - S12TSUADCMPI: Comparison result interrupt signal (level)

So I'd go for "adi" and "adcmpi".

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds