Re: [PATCH][next] scripts/sorttable: Fix resource leak on file pointer fp

From: Colin King (gmail)
Date: Thu Feb 27 2025 - 05:00:08 EST


On 27/02/2025 09:57, Dan Carpenter wrote:
On Wed, Feb 26, 2025 at 10:49:34PM +0000, Colin Ian King wrote:
There is a resource leak on fp on an error return path in function
parse_symbols that causes a resource leak. Fix this by adding in
the missing fclose.

Fixes: ef378c3b8233 ("scripts/sorttable: Zero out weak functions in mcount_loc table")
Signed-off-by: Colin Ian King <colin.i.king@xxxxxxxxx>

This is in scripts/ so it doesn't really matter. We're going to exit
and release everything immediately either way.

Ack. Won't fix these issues in scripts in future.


regards,
dan carpenter


Attachment: OpenPGP_0x68C287DFC6A80226.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature