Re: [PATCH net-next v7 6/8] net: pktgen: fix mpls reset parsing

[Paolo Abeni]

On 2/24/25 10:22 AM, Peter Seiderer wrote:
> diff --git a/net/core/pktgen.c b/net/core/pktgen.c
> index ae5e81e62733..bb13a4591709 100644
> --- a/net/core/pktgen.c
> +++ b/net/core/pktgen.c
> @@ -915,8 +915,13 @@ static ssize_t get_labels(const char __user *buffer,
>  
>  		max = min(8, maxlen - i);
>  		len = hex32_arg(&buffer[i], max, &tmp);
> -		if (len <= 0)
> +		if (len < 0)
>  			return len;
> +
> +		// return empty list in case of invalid input and/or zero value

I'm sorry for nit picking, but C-99 comments should be avoided

Thanks,

Paolo