Re: [PATCH v5 10/21] acpi/ghes: create an ancillary acpi_ghes_get_state() function

[Mauro Carvalho Chehab]

Em Thu, 27 Feb 2025 12:03:40 +0100
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> escreveu:

> Instead of having a function to check if ACPI is enabled
> (acpi_ghes_present), change its logic to be more generic,
> returing a pointed to AcpiGhesState.
> 
> Such change allows cleanup the ghes GED state code, avoiding
> to read it multiple times, and simplifying the code.
> 
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>
> Reviewed-by:  Igor Mammedov <imammedo@xxxxxxxxxx>
> ---
>  hw/acpi/ghes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c
> index c3a64adfe5ed..0135ac844bcf 100644
> --- a/hw/acpi/ghes.c
> +++ b/hw/acpi/ghes.c
> @@ -608,7 +608,7 @@ AcpiGhesState *acpi_ghes_get_state(void)
>      }
>      ags = &acpi_ged_state->ghes_state;
>  
> -    if (!ags->hw_error_le) {
> +    if (!ags->hw_error_le && !ags->hest_addr_le) {
>          return NULL;
>      }
>      return ags;

Sorry, I moved most of the stuff on this patch to 
	[PATCH 04/21] acpi/ghes: Cleanup the code which gets ghes ged state

This hunk was a left over from it. I was meant to place this hunk
elsewhere but I ended forgetting while waiting for the rebase bisect
tests to pass.

 I'll move this hunk to
	[PATCH 06/21] acpi/ghes: add a firmware file with HEST address

for the next respin (and hopefully the final one).

Regards,
Mauro