Re: [PATCH] drm/xe: Select INTEL_VSEC to fix build dependency

[Su Hui]

On 2025/2/27 18:47, Jani Nikula wrote:
> On Thu, 27 Feb 2025, Su Hui <suhui@xxxxxxxxxxxx> wrote:
> > When build randconfig, there is an error:
> > ld: drivers/gpu/drm/xe/xe_vsec.o: in function `xe_vsec_init':
> > xe_vsec.c:(.text+0x182): undefined reference to `intel_vsec_register'
> >
> > When CONFIG_DRM_XE=y and CONFIG_INTEL_VSEC=m is set, ld couldn't find
> > 'intel_vsec_register'. Select INTEL_VSEC to fix this error.
> Documentation/kbuild/kconfig-language.rst:
>
>    Note:
> 	select should be used with care. select will force
> 	a symbol to a value without visiting the dependencies.
> 	By abusing select you are able to select a symbol FOO even
> 	if FOO depends on BAR that is not set.
> 	In general use select only for non-visible symbols
> 	(no prompts anywhere) and for symbols with no dependencies.
> 	That will limit the usefulness but on the other hand avoid
> 	the illegal configurations all over.
>
> This should likely be either
>
> 	depends on INTEL_VSEC || INTEL_VSEC=n
>
> or
>
> 	depends on INTEL_VSEC

Hi, Jani:

I tried to use 'depends on' at first. But there is a recursive dependency:

    error: recursive dependency detected!
        symbol DRM_XE depends on INTEL_VSEC
        symbol INTEL_VSEC depends on X86_PLATFORM_DEVICES
        symbol X86_PLATFORM_DEVICES is selected by DRM_XE
        For a resolution refer to 
Documentation/kbuild/kconfig-language.rst
    subsection "Kconfig recursive dependency limitations".


I will try it again with 'depends on', need some time to check this 
recursive
dependency problem.

Su Hui

> > Fixes: 0c45e76fcc62 ("drm/xe/vsec: Support BMG devices")
> > Signed-off-by: Su Hui <suhui@xxxxxxxxxxxx>
> > ---
> >   drivers/gpu/drm/xe/Kconfig | 1 +
> >   1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/xe/Kconfig b/drivers/gpu/drm/xe/Kconfig
> > index b51a2bde73e2..7a60d96d2dd6 100644
> > --- a/drivers/gpu/drm/xe/Kconfig
> > +++ b/drivers/gpu/drm/xe/Kconfig
> > @@ -44,6 +44,7 @@ config DRM_XE
> >   	select WANT_DEV_COREDUMP
> >   	select AUXILIARY_BUS
> >   	select HMM_MIRROR
> > +	select INTEL_VSEC
> >   	help
> >   	  Experimental driver for Intel Xe series GPUs