Re: [PATCH v4 01/10] dt-bindings: PCI: Add binding for Toshiba TC956x PCIe switch

[Krzysztof Kozlowski]

On 27/02/2025 04:53, Krishna Chaitanya Chundru wrote:
>>> +
>>> +patternProperties:
>>> +  "^pcie@[1-3],0$":
>>> +    description:
>>> +      child nodes describing the internal downstream ports
>>> +      the tc956x switch.
>>> +    type: object
>>> +    $ref: "#/$defs/tc956x-node"
>>> +    unevaluatedProperties: false
>>> +
>>> +$defs:
>>> +  tc956x-node:
>>> +    type: object
>>> +
>>> +    properties:
>>> +      tc956x,tx-amplitude-microvolt:
>>
>> You already got comments on this.
>>
> In V3 I got a comment saying "-microvolt does not work for you?"
> so based on this we changed to microvolt.


And then what pops up when you test? Drop ref which is pointed out by
testing, example-schema and all other bindings.

Best regards,
Krzysztof