Re: [PATCH v5 17/21] tests/acpi: virt: update HEST table to accept two sources

From: Igor Mammedov
Date: Thu Feb 27 2025 - 08:11:14 EST

On Thu, 27 Feb 2025 12:03:47 +0100
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:

squash this patch into the next one

Also at this point there is no visible HEST changes yet, so a soon as you remove
white-list without enabling new HEST, the tests should start failing.

I suggest to move 20/21 before this patch,
as result one would see dsdt and hest diffs when running tests
and then you can use rebuild-expected-aml.sh to generate updated
tables and update them in one patch (that's what we typically do,
we don't split updates in increments).


> --- /tmp/asl-38PE22.dsl 2025-02-26 16:25:32.362148388 +0100
> +++ /tmp/asl-HSPE22.dsl 2025-02-26 16:25:32.361148402 +0100
> @@ -1,39 +1,39 @@
> /*
> * Intel ACPI Component Architecture
> * AML/ASL+ Disassembler version 20240322 (64-bit version)
> * Copyright (c) 2000 - 2023 Intel Corporation
> *
> - * Disassembly of tests/data/acpi/aarch64/virt/HEST
> + * Disassembly of /tmp/aml-DMPE22
> *
> * ACPI Data Table [HEST]
> *
> * Format: [HexOffset DecimalOffset ByteLength] FieldName : FieldValue (in hex)
> */
>
> [000h 0000 004h] Signature : "HEST" [Hardware Error Source Table]
> -[004h 0004 004h] Table Length : 00000084
> +[004h 0004 004h] Table Length : 000000E0
> [008h 0008 001h] Revision : 01
> -[009h 0009 001h] Checksum : E2
> +[009h 0009 001h] Checksum : 6C
> [00Ah 0010 006h] Oem ID : "BOCHS "
> [010h 0016 008h] Oem Table ID : "BXPC "
> [018h 0024 004h] Oem Revision : 00000001
> [01Ch 0028 004h] Asl Compiler ID : "BXPC"
> [020h 0032 004h] Asl Compiler Revision : 00000001
>
> -[024h 0036 004h] Error Source Count : 00000001
> +[024h 0036 004h] Error Source Count : 00000002
>
> [028h 0040 002h] Subtable Type : 000A [Generic Hardware Error Source V2]
> [02Ah 0042 002h] Source Id : 0000
> [02Ch 0044 002h] Related Source Id : FFFF
> [02Eh 0046 001h] Reserved : 00
> [02Fh 0047 001h] Enabled : 01
> [030h 0048 004h] Records To Preallocate : 00000001
> [034h 0052 004h] Max Sections Per Record : 00000001
> [038h 0056 004h] Max Raw Data Length : 00000400
>
> [03Ch 0060 00Ch] Error Status Address : [Generic Address Structure]
> [03Ch 0060 001h] Space ID : 00 [SystemMemory]
> [03Dh 0061 001h] Bit Width : 40
> [03Eh 0062 001h] Bit Offset : 00
> [03Fh 0063 001h] Encoded Access Width : 04 [QWord Access:64]
> [040h 0064 008h] Address : 0000000043DA0000
> @@ -42,32 +42,75 @@
> [048h 0072 001h] Notify Type : 08 [SEA]
> [049h 0073 001h] Notify Length : 1C
> [04Ah 0074 002h] Configuration Write Enable : 0000
> [04Ch 0076 004h] PollInterval : 00000000
> [050h 0080 004h] Vector : 00000000
> [054h 0084 004h] Polling Threshold Value : 00000000
> [058h 0088 004h] Polling Threshold Window : 00000000
> [05Ch 0092 004h] Error Threshold Value : 00000000
> [060h 0096 004h] Error Threshold Window : 00000000
>
> [064h 0100 004h] Error Status Block Length : 00000400
> [068h 0104 00Ch] Read Ack Register : [Generic Address Structure]
> [068h 0104 001h] Space ID : 00 [SystemMemory]
> [069h 0105 001h] Bit Width : 40
> [06Ah 0106 001h] Bit Offset : 00
> [06Bh 0107 001h] Encoded Access Width : 04 [QWord Access:64]
> -[06Ch 0108 008h] Address : 0000000043DA0008
> +[06Ch 0108 008h] Address : 0000000043DA0010
>
> [074h 0116 008h] Read Ack Preserve : FFFFFFFFFFFFFFFE
> [07Ch 0124 008h] Read Ack Write : 0000000000000001
>
> -Raw Table Data: Length 132 (0x84)
> +[084h 0132 002h] Subtable Type : 000A [Generic Hardware Error Source V2]
> +[086h 0134 002h] Source Id : 0001
> +[088h 0136 002h] Related Source Id : FFFF
> +[08Ah 0138 001h] Reserved : 00
> +[08Bh 0139 001h] Enabled : 01
> +[08Ch 0140 004h] Records To Preallocate : 00000001
> +[090h 0144 004h] Max Sections Per Record : 00000001
> +[094h 0148 004h] Max Raw Data Length : 00000400
> +
> +[098h 0152 00Ch] Error Status Address : [Generic Address Structure]
> +[098h 0152 001h] Space ID : 00 [SystemMemory]
> +[099h 0153 001h] Bit Width : 40
> +[09Ah 0154 001h] Bit Offset : 00
> +[09Bh 0155 001h] Encoded Access Width : 04 [QWord Access:64]
> +[09Ch 0156 008h] Address : 0000000043DA0008
> +
> +[0A4h 0164 01Ch] Notify : [Hardware Error Notification Structure]
> +[0A4h 0164 001h] Notify Type : 07 [GPIO]
> +[0A5h 0165 001h] Notify Length : 1C
> +[0A6h 0166 002h] Configuration Write Enable : 0000
> +[0A8h 0168 004h] PollInterval : 00000000
> +[0ACh 0172 004h] Vector : 00000000
> +[0B0h 0176 004h] Polling Threshold Value : 00000000
> +[0B4h 0180 004h] Polling Threshold Window : 00000000
> +[0B8h 0184 004h] Error Threshold Value : 00000000
> +[0BCh 0188 004h] Error Threshold Window : 00000000
> +
> +[0C0h 0192 004h] Error Status Block Length : 00000400
> +[0C4h 0196 00Ch] Read Ack Register : [Generic Address Structure]
> +[0C4h 0196 001h] Space ID : 00 [SystemMemory]
> +[0C5h 0197 001h] Bit Width : 40
> +[0C6h 0198 001h] Bit Offset : 00
> +[0C7h 0199 001h] Encoded Access Width : 04 [QWord Access:64]
> +[0C8h 0200 008h] Address : 0000000043DA0018
>
> - 0000: 48 45 53 54 84 00 00 00 01 E2 42 4F 43 48 53 20 // HEST......BOCHS
> +[0D0h 0208 008h] Read Ack Preserve : FFFFFFFFFFFFFFFE
> +[0D8h 0216 008h] Read Ack Write : 0000000000000001
> +
> +Raw Table Data: Length 224 (0xE0)
> +
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx>
> ---
> tests/data/acpi/aarch64/virt/HEST | Bin 132 -> 224 bytes
> 1 file changed, 0 insertions(+), 0 deletions(-)
>
> diff --git a/tests/data/acpi/aarch64/virt/HEST b/tests/data/acpi/aarch64/virt/HEST
> index 4c5d8c5b5da5b3241f93cd0839e94272bf6b1486..674272922db7d48f7821aa7c83ec76bb3b556d2a 100644
> GIT binary patch
> delta 68
> zcmZo+e89-%;TjzBfPsO5F=rx|6eH6_Rd+^#iMisuTnvm1|Nk>EGJ@nLCJHmL%S;Ru
> WnV7)J#lXPAz`)?Zz#=g*R~!HcF%5eF
>
> delta 29
> lcmaFB*uu!=;Tjy$!oa}5_-G=R6eHtARriT=I3|_|004Ge2nqlI
>