Re: [PATCH] ASoC: mediatek: mt8188: avoid uninitialized variable use

From: Nícolas F. R. A. Prado
Date: Thu Feb 27 2025 - 08:28:10 EST


On Thu, Feb 27, 2025 at 02:19:01PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
>
> The 'msk' variable has no initialization:
>
> sound/soc/mediatek/mt8188/mt8188-dai-dmic.c:311:4: error: variable 'msk' is uninitialized when used here [-Werror,-Wuninitialized]
> 311 | msk |= PWR2_TOP_CON1_DMIC_FIFO_SOFT_RST_EN(i);
> | ^~~
>
> Set it to zero before the loop.
>
> Fixes: c1e42ec04197 ("ASoC: mediatek: mt8188: Add support for DMIC")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Nícolas F. R. A. Prado <nfraprado@xxxxxxxxxxxxx>

Sorry about the delay, I was about to send this myself.

Thanks,
Nícolas