Re: [PATCH] rust: miscdevice: change how f_ops vtable is constructed

From: Alice Ryhl
Date: Thu Feb 27 2025 - 08:30:03 EST


On Thu, Feb 27, 2025 at 2:23 PM Alice Ryhl <aliceryhl@xxxxxxxxxx> wrote:
>
> I was helping someone with writing a new Rust abstraction, and we were
> using the miscdevice abstraction as an example. While doing this, it
> became clear to me that the way I implemented the f_ops vtable is
> confusing to new Rust users, and that the approach used by the block
> abstractions is less confusing.
>
> Thus, update the miscdevice abstractions to use the same approach as
> rust/kernel/block/mq/operations.rs.
>
> Sorry about the large diff. This changes the indentation of a large
> amount of code.
>
> Reviewed-by: Christian Schrefl <chrisi.schrefl@xxxxxxxxx>
> Signed-off-by: Alice Ryhl <aliceryhl@xxxxxxxxxx>

I think I must have misused b4 somehow, because this lost the v2 marker ...

This is version 2, and the previous version is here:
https://lore.kernel.org/all/20250117-miscdevice-fops-change-v1-1-ec04b701c076@xxxxxxxxxx/

The only change is rebase on v6.14-rc2.

Alice