Re: [PATCH] xen/pciback: Make missing GSI non-fatal

From: Jason Andryuk
Date: Thu Feb 27 2025 - 10:14:50 EST


On 2025-02-26 22:36, Chen, Jiqian wrote:
On 2025/2/27 04:01, Jason Andryuk wrote:
@@ -475,14 +478,14 @@ static int pcistub_init_device(struct pcistub_device *psdev)
#ifdef CONFIG_XEN_ACPI
if (xen_initial_domain() && xen_pvh_domain()) {
err = xen_acpi_get_gsi_info(dev, &gsi, &trigger, &polarity);
- if (err) {
- dev_err(&dev->dev, "Fail to get gsi info!\n");
- goto config_release;
+ if (err && err != -ENOENT) {
+ dev_err(&dev->dev, "Failed to get gsi info! %d\n", err);
I think here needs " goto config_release;" since it is not ENOENT error.

Yes, thank you for catching that.

Regards,
Jason