Re: [PATCH v5 17/21] tests/acpi: virt: update HEST table to accept two sources

[Mauro Carvalho Chehab]

Em Thu, 27 Feb 2025 16:51:24 +0100
Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> escreveu:

> Em Thu, 27 Feb 2025 14:16:03 +0100
> Igor Mammedov <imammedo@xxxxxxxxxx> escreveu:
> 
> > On Thu, 27 Feb 2025 14:10:38 +0100
> > Igor Mammedov <imammedo@xxxxxxxxxx> wrote:
> >   
> > > On Thu, 27 Feb 2025 12:03:47 +0100
> > > Mauro Carvalho Chehab <mchehab+huawei@xxxxxxxxxx> wrote:
> > > 
> > > squash this patch into the next one
> > > 
> > > Also at this point there is no visible HEST changes yet, so a soon as you remove
> > > white-list without enabling new HEST, the tests should start failing.
> > > 
> > > I suggest to move 20/21 before this patch,
> > > as result one would see dsdt and hest diffs when running tests
> > > and then you can use rebuild-expected-aml.sh to generate updated
> > > tables and update them in one patch (that's what we typically do,
> > > we don't split updates in increments).    
> > 
> > on top of that,
> > it seems the patch doesn't apply for some reason.  
> 
> Hmm... perhaps the diffstat that I place here (produced by bios-tables-test
> output) is causing some confusion when you're trying to apply the patch.
> 
> Any suggestions to avoid that?

Nevermind. I fixed by removing the name of the file before the diff, e.g.
the description is now:

  tests/acpi: virt: update HEST and DSDT tables
    
    - The HEST table now accept two sources;
    - The DSDT tables now have a GED error device.
    
    @@ -1,39 +1,39 @@
     /*
      * Intel ACPI Component Architecture
      * AML/ASL+ Disassembler version 20240322 (64-bit version)
      * Copyright (c) 2000

...

Regards,
Mauro