Re: [PATCH] net: qed: make 'qed_ll2_ops_pass' as __maybe_unused

[Simon Horman]

+ Andrew, Dave, Eric, Jakub, and Paolo

On Tue, Feb 25, 2025 at 09:09:23PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@xxxxxxxx>
> 
> gcc warns about unused const variables even in header files when
> building with W=1:
> 
>     In file included from include/linux/qed/qed_rdma_if.h:14,
>                      from drivers/net/ethernet/qlogic/qed/qed_rdma.h:16,
>                      from drivers/net/ethernet/qlogic/qed/qed_cxt.c:23:
>     include/linux/qed/qed_ll2_if.h:270:33: error: 'qed_ll2_ops_pass' defined but not used [-Werror=unused-const-variable=]
>       270 | static const struct qed_ll2_ops qed_ll2_ops_pass = {
> 
> This one is intentional, so mark it as __maybe_unused to it can be
> included from a file that doesn't use this variable.
> 
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>

Reviewed-by: Simon Horman <horms@xxxxxxxxxx>
Tested-by: Simon Horman <horms@xxxxxxxxxx> # build-tested

This is marked as being not a local patch in netdev patchwork.
That doesn't seem right to me and perhaps this will address that.

pw-bot: under-review

Possibly this because is because while qed_rdma_if.h is
included in the QLOGIC QL4xxx ETHERNET DRIVER section
of MAINTAINERS, it is not included in the NETWORKING DRIVERS section.

I will plan to submit a patch to address that.