Re: [PATCH RFC v1 01/11] x86/fpu/xstate: Simplify print_xstate_features()

From: Dave Hansen
Date: Thu Feb 27 2025 - 13:53:33 EST


On 2/27/25 10:44, Chang S. Bae wrote:
> I find it difficult to justify using separate lines for printing when
> they can be efficiently grouped under a simple for-loop. While this
> cleanup isn't directly related to APX, it felt like a necessary
> improvement, especially when new xstates are introduced.

Yeah, this approach made some sense when the string was defined there too:

print_xstate_feature(XSTATE_OPMASK, "AVX-512 opmask");
print_xstate_feature(XSTATE_ZMM_Hi256, "AVX-512 Hi256");
...

But it doesn't now that the strings are in a separate structure.

Reviewed-by: Dave Hansen <dave.hansen@xxxxxxxxxxxxxxx>